| View previous topic :: View next topic |
| Author |
Message |
Captain Caveman Jammer

Joined: 21 Feb 2006 Posts: 42 Location: The Megacontinent
|
Posted: Mon Sep 09, 2013 6:06 pm Post subject: |
|
|
Apologies to everyone, because those other versions were completely broken. Well, they worked at 120bpm at 4/4 but at no other tempos or time signatures.
Now it works with the time signature in Project Settings (not tempo markers or envelopes). I've tested 2/4, 3/4, 4/4 and 6/8 anyway.
Now it almost certainly works properly.  |
|
| Back to top |
|
 |
Azimuth Moderator & Beta Team

Joined: 19 Nov 2010 Posts: 2131
|
Posted: Mon Sep 09, 2013 10:37 pm Post subject: |
|
|
Let me get this straight.... you're doing something to help us and you're apologizing? Seriously, thanks man for doing this. It really is going to be a big time saver.
EDIT: I made a few minor changes to the script. The length for Drum Solo should be "A4" vs. "A1" because JS creates it as 1 bar with 4 repetitions. I also changed the naming of Pre-Chorus to Pre-Chor and Drum Solo to Drumsolo so the SWS Autocolor extension could differentiate between the regions.
I don't quite understand why but Autocolor can differentiate between Solo and Drumsolo but not between Prechorus and Chorus..... strange.
RE-EDIT: The Drum Solo length is still wrong for non-standard verse lengths. I'll check it out further tonight.
RE-RE-EDIT: The length for Drum Solo should be 'VS', Drum Solo follows verse length. The script still can not work correctly if Verses or Choruses contain an odd number of bars. JS rounds down to the next integer but the script does not.
Last edited by Azimuth on Wed Sep 11, 2013 2:41 am; edited 6 times in total |
|
| Back to top |
|
 |
roy_arn Junior Jammer

Joined: 04 Mar 2013 Posts: 17 Location: United Kingdom
|
Posted: Tue Sep 10, 2013 11:17 am Post subject: |
|
|
Intro too long, not sure about verses etc because intro length throws the rest out.
Roy |
|
| Back to top |
|
 |
Azimuth Moderator & Beta Team

Joined: 19 Nov 2010 Posts: 2131
|
Posted: Wed Sep 11, 2013 12:42 am Post subject: |
|
|
| Roy, the Intro length is always 2 Bars long unless manually changed. What is happening with your setup? |
|
| Back to top |
|
 |
Captain Caveman Jammer

Joined: 21 Feb 2006 Posts: 42 Location: The Megacontinent
|
Posted: Wed Sep 11, 2013 8:30 am Post subject: |
|
|
@a_zimuth: Thanks for the info, I've updated it so it rounds down any fractions either in the input fields or the subsequent divisions. (and changed the drum solo length)
@roy_arn: I don't know what's happening because as far as I can see the Intro is always 2 bars long. Could you redownload the latest version to make sure we are all on the same page and check again? |
|
| Back to top |
|
 |
roy_arn Junior Jammer

Joined: 04 Mar 2013 Posts: 17 Location: United Kingdom
|
Posted: Wed Sep 11, 2013 12:01 pm Post subject: |
|
|
O.K. Looking better on a quick test getting an intro of 2 bars now with todays file. need to test on my music computer. but was getting 2 and a bit bars on previous file. so fingers crossed.
thank you
Roy |
|
| Back to top |
|
 |
Azimuth Moderator & Beta Team

Joined: 19 Nov 2010 Posts: 2131
|
Posted: Wed Sep 11, 2013 2:04 pm Post subject: |
|
|
| Captain, Quick test with latest version using a 6/8, 5 bars/verse, 3 bars/chorus JS song and all looks good. I have no idea where/how you are finding ReaScript documentation to solve these problems as they arise. I tried looking into the rounding problem myself and that wiki is a total head-scratcher IMO. |
|
| Back to top |
|
 |
roy_arn Junior Jammer

Joined: 04 Mar 2013 Posts: 17 Location: United Kingdom
|
Posted: Wed Sep 11, 2013 2:47 pm Post subject: |
|
|
Sorry about this Captain Caveman, but the problems I'm getting are on just one midi project that I've been trying your script on. I've just tried three more projects and it works well. So I need to explore this one project and see what's throwing it out. Intro ends about 2 bars and a little over a 1/16th.
I'll let you know if I figure it out.
Best Roy |
|
| Back to top |
|
 |
Captain Caveman Jammer

Joined: 21 Feb 2006 Posts: 42 Location: The Megacontinent
|
Posted: Wed Sep 11, 2013 5:53 pm Post subject: |
|
|
@a_zimuth: if you go to Help -> HTML lists -> ReaScript documentation Reaper shows the current API. Rounding crapola crops up all the time, with Python it turns out that an int isn't the integer found in every other programming language in the universe, but a 32 bit precision float so an additional floor() was required. I moan, but it's all good fun.
@roy_arn: that's good to know. Maybe there is a tempo change at the beginning (or time sig), because the script does not take them into account. The script places regions in the timeline by absolute time (ie seconds), not bars or beats so tempo changes (or time sigs) in the project before using it will throw it off. It's not fit for Math Rock atm (well it is, as long as the markers are placed afterwards). I might geek tease myself into getting the bells n whistles put on at some point but if it works for everyone at the mo with the known limitations I'll leave it for now. |
|
| Back to top |
|
 |
Azimuth Moderator & Beta Team

Joined: 19 Nov 2010 Posts: 2131
|
Posted: Thu Sep 12, 2013 3:33 am Post subject: |
|
|
Captain, the script has handled everything I've thrown at it perfectly, totally usable now. (provided that I remember to reset the song structure ) Thanks for the info regarding the documentation. If you ever decide to implement some bells and whistles that would be great. I can however, live with it just the way it is now. Now let's go make some music because that's what this is supposed to be about after all.  |
|
| Back to top |
|
 |
roy_arn Junior Jammer

Joined: 04 Mar 2013 Posts: 17 Location: United Kingdom
|
Posted: Fri Sep 13, 2013 2:29 am Post subject: |
|
|
Seems to be all going well for me too, just removed a tempo marker and reset project tempo to required speed, and even the problem project works as expected. Thanks Captain for all your graft, much appreciated.
Roy |
|
| Back to top |
|
 |
Jae.Thomas Grand Master Jam

Joined: 06 Jun 2006 Posts: 280
|
Posted: Sat Mar 12, 2022 12:55 pm Post subject: |
|
|
| I feel like this script used to work a lot better - and quicker. I can't seem to get it working anymore... |
|
| Back to top |
|
 |
|